review · segments

Untitled session

claude 115 events 1 segments main

segment 1 of 1

Audit the ambassador referral system for correctness and edge cases

Done

Read all referral-related files including ReferralRewardService, ReferralAttributionService, ReferralCodeService, AmbassadorInvitationService, FreeTierLimitResolver, FreeTierLimits, QualifyReferralOnVodArchived, models, migrations, tests, admin settings, and support classes. Analyzed logic for ambassador storage allocation, multiplier sync, qualification, retention, size/duration caps, keep-forever, code rename/redirect, and free-tier assignment. Identified multiple high and medium priority issues including synchronous listener failure risk, per-Twitch-account storage assignment for multi-account ambassadors being overwritten, and lack of retroactive storage recalculation after promotion.

outcome

A prioritized markdown audit report was produced with findings: HIGH - synchronous listener can fail archive after success; HIGH - syncAmbassadorStorage overwrites max_storage_bytes for non-primary accounts; HIGH - no retroactive storage recalculation on promotion; MEDIUM - chained code rename redirect loop; MEDIUM - ambassador dashboard shows aggregated stats across all codes but only current code's overlay; MEDIUM - free_tier_bonus_referrer_user_id lost on attribute; MEDIUM - referredMultiplierFor includes self-referral in totalQualified count; MEDIUM - ambassador free-tier count limits set to null but FreeTierLimits still checks bucket limits; LOW - admin ambassador detail calls syncAmbassadorStorage on every load.

next steps

—

key decisions

No decisions made; this was a review-only session without code changes.

open questions

—

2 days ago → 2 days ago