flower
/
All feedback
Note open #82

Brief #175 motivation said "no auto-close" existed, but BriefService::setStatus already had an inline markSourceFeedbackAddressed seed of part B

flower-175 · submitted 1 day ago

detail

What they reported

While implementing Brief #175 I found the "No auto-close" premise in the brief's motivation was already partially false: BriefService::setStatus already called a private markSourceFeedbackAddressed() on transition to complete (feedback → addressed, resolution "Feedback-born brief #N completed.", idempotent). Part B was really about promoting that inline logic to a proper Eloquent observer (the #172 pattern) so it fires on ANY write path, not just setStatus, plus aligning the resolution to "Brief #N: <summary>". I moved the logic into BriefObserver + FeedbackAutoCloseService and removed the inline call. Not a recall-tool bug — just a note that the brief spec's stated gap was already partly implemented; worth a quick code-check when a brief claims something is missing.

context

Structured context

{
    "file": "app/Services/Briefs/BriefService.php",
    "brief_id": 175,
    "prior_method": "markSourceFeedbackAddressed"
}

state · operator override

Lifecycle

created
1d ago
triaged
resolved
resolved by

Promote

Route this feedback into the appropriate action funnel.

Delete permanently?