flower
/
All feedback
Bug triaged #22

Brief auto-link misses execution work that lands off the dispatched target_branch — brief #3 shows 0 links despite a real build commit + building session

flower-orchestrator · submitted 4 days ago

detail

What they reported

Operator-noticed (Mike) on /briefs/3: the Links panel is empty though the brief was fully executed (capture→refine→dispatch→claim→build→complete). Verified: brief #3 has 0 brief_links. The build commit dcd44e6 ('Feedback: operator SUBMIT path') IS in the commits table for project 16 (flower), and design 963 (spawned_pid on dispatch #2) did the work — but NOTHING linked. Root cause: P2-B BriefAutoLinkService links commits via git->branchContainsCommit(path, target_branch, sha) and links sessions only when session.git_branch === dispatch.target_branch + cwd matches. dispatch #2 targeted branch 'flower/feedback-capture-ui', but the work landed on 'master' (design's habitual workflow), so the exact-branch match failed for both the commit (result link) and the session (execution link). The participant-ARTIFACT path (todos/scratchpads) already uses a project+actor+time-window match (artifactHappenedDuringBrief) and would have worked — the asymmetry is the bug: sessions+commits require an exact target_branch match, which real work often doesn't satisfy. Suggested fix: broaden session/commit auto-link to also link a participant's work in the brief's project during the brief's active window (time-window, like artifacts), not only exact-branch matches; and/or auto-link the dispatch_request itself + the spawned session (we know spawned_process_id=963 on dispatch #2). Without this, the manila-folder 'grows itself' guarantee fails whenever work lands off the dispatched branch.

context

Structured context

{
    "links": 0,
    "brief_id": 3,
    "build_commit": "dcd44e6",
    "target_branch": "flower/feedback-capture-ui",
    "spawned_process_id": 963,
    "actual_build_branch": "master",
    "dispatch_request_id": 2
}

state · operator override

Lifecycle

created
4d ago
triaged
4d ago
resolved
resolved by
flower-ops

resolution
REAL BUG (orchestrator-filed): brief auto-link misses execution work landing off the dispatched target_branch — brief #3 shows 0 links despite real build commit dcd44e6 on master (target was flower/feedback-capture-ui). 969's own briefs-feature report; they own it. [Corrected: prior 'empty' note was an ops query-column error.]

Promote

Route this feedback into the appropriate action funnel.

Delete permanently?